KUBESAW-174: Print error output for repos where verification failed#458
Merged
fbm3307 merged 13 commits intocodeready-toolchain:masterfrom Jan 31, 2025
Merged
KUBESAW-174: Print error output for repos where verification failed#458fbm3307 merged 13 commits intocodeready-toolchain:masterfrom
fbm3307 merged 13 commits intocodeready-toolchain:masterfrom
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
alexeykazakov,
mfrancisc,
rajivnathan,
ranakan19 and
xcoulon
as code owners
mfrancisc
reviewed
Jan 21, 2025
Contributor
mfrancisc
left a comment
mfrancisc
left a comment
There was a problem hiding this comment.
Looks good!
I have one minor comment about the regex.
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
mfrancisc
reviewed
Jan 27, 2025
metlos
reviewed
Jan 27, 2025
Contributor
metlos
left a comment
metlos
left a comment
There was a problem hiding this comment.
Looks good apart from some minor comments.
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
metlos
reviewed
Jan 29, 2025
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
MatousJobanek
approved these changes
Jan 31, 2025
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to update the verify dependency script such a way that it prints the error/failure in an understandable way
Checks
Did you run
make generatetarget? NADid
make generatechange anything in other projects (host-operator, member-operator)? NAIn case of new CRD, did you the following? NA
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.